Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): meter_with_version should accept optional parameter for optional parameters. #752

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Mar 10, 2022

Follow up on #743

BREAKING CHANGES:

  • meter_with_version will not accpet Optional as 2nd and 3rd parameters

@TommyCpp TommyCpp requested a review from a team March 10, 2022 07:00
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #752 (0af43d3) into main (087fd80) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   70.19%   70.22%   +0.03%     
==========================================
  Files         108      108              
  Lines        8804     8804              
==========================================
+ Hits         6180     6183       +3     
+ Misses       2624     2621       -3     
Impacted Files Coverage Δ
opentelemetry-api/src/global/metrics.rs 100.00% <100.00%> (+16.66%) ⬆️
opentelemetry-otlp/src/span.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087fd80...0af43d3. Read the comment docs.

@TommyCpp TommyCpp merged commit 027c1f8 into open-telemetry:main Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants